Closed mpourismaiel closed 5 years ago
@farnabaz Is there anything else wrong or problematic with the PR?
@mpourismaiel I add a test for subtract
function
Also, I don't think this it is a good idea to manipulate $set
function to handle subtract logic, there should be a simpler way to fix this issue
There is. We would need to change calendar
module but that is out of the scope of my expertise. This is a dirty patch to fix the problem for now, a better fix would be to either make calendar
module handle negative values.
Thanks 🍺
UPDATE: Sorry my previous commit (removed by force push) didn't solve the problem. Also removed the PR note so this one is the new one.
endOf
anddaysInMonth
functionalitysubtract
issueIssues fixed
Tests