alibaba / GraphScope

🔨 🍇 💻 🚀 GraphScope: A One-Stop Large-Scale Graph Computing System from Alibaba | 一站式图计算系统
https://graphscope.io
Apache License 2.0
3.29k stars 444 forks source link

rapidjson v.s. nlohmannjson #4143

Closed yecol closed 1 month ago

yecol commented 2 months ago

For the same purpose, it is very wired to use two different json libraries in a single repo.

@zhanglei1949, as the one introducing the second json lib, you are obligated to compare the two libs and:

P.S. I will add a CI or post-commit hook to ask every PR explicitly to declare when introducing new third-party dependencies.

zhanglei1949 commented 2 months ago

I find nlohmann json easy to use, but rapidjson offers better performance. We should consider switching to rapidjson.

zhanglei1949 commented 1 month ago

Closed since resolved.