Closed yecol closed 1 month ago
For the same purpose, it is very wired to use two different json libraries in a single repo.
@zhanglei1949, as the one introducing the second json lib, you are obligated to compare the two libs and:
rapidjson
P.S. I will add a CI or post-commit hook to ask every PR explicitly to declare when introducing new third-party dependencies.
I find nlohmann json easy to use, but rapidjson offers better performance. We should consider switching to rapidjson.
Closed since resolved.
For the same purpose, it is very wired to use two different json libraries in a single repo.
@zhanglei1949, as the one introducing the second json lib, you are obligated to compare the two libs and:
rapidjson
usage.P.S. I will add a CI or post-commit hook to ask every PR explicitly to declare when introducing new third-party dependencies.