Closed yecol closed 3 years ago
@shirly121 @zhengpingq, how do you think, could you give some comments? If the proposal is workable, I think zedong or weibin can help for the implementation.
And the scripts under
interactive_engine/src/instance-manager/script/*
can also unified:
├── bin
│ ├── start.sh
│ └── stop.sh
├── config
│ ├── application.properties
│ ├── coordinator.local.application.properties.tpl
│ ├── executor.local.vineyard.properties.tpl
│ └── frontend.local.vineyard.properties.tpl
├── script
│ ├── close_local_instance.sh
│ ├── common.sh
│ ├── create_local_instance.sh
│ ├── start_local_coordinator.sh
│ ├── start_local_executor.sh
│ └── start_local_frontend.sh
Better seperate gie and v2, and put v2 related scripts under interactive_engine/distribution
.
It seems in the current version, the scripts for GIE are not well organized. I suggest we reorg the files in
/interactive_engine/distribution
and/interactive_engine/deploy
Currently, the file tree of distribution:
problems:
bin
folder are quite simple, all of them are one-line command of Java. I think we can aggregate them to a single binary executable (e.g.,giectl
) with sub-command. likegiectl start-coordinator
,giectl start-frontend
,giectl start-all
...For
interactive_engine/deploy
folder, currently the files are organized like this:Similar to the files in distribution, most of the files are simple wrappers for a single-line Java command. In addition, it seems many files are for the same functions as those in
distribution
. (As the filename implies, starting coordinator/front-end and exposing an entrypoint.) It would be better if the scripts to start the coordinator (and for others) can be unified, whether to start it in a docker container/ or in a physical machine (or local). We may not need a set of docker-specific scripts and thegiectl
is sufficient.I suggest we reorg them as: