search

alibaba / PhotonLibOS

Probably the fastest coroutine lib in the world!
https://PhotonLibOS.github.io
Apache License 2.0
874 stars 116 forks source link

[Discussion] Add ENABLE_TLS option #331

Open beef9999 opened 9 months ago

beef9999 commented 9 months ago

We already have the ENABLE_SASL option which is default OFF, and we used to regard that SSL module is a MUST HAVE.

But the SSL init in net/security-context/tls-stream.cpp will register Photon mutex, and will potentially cause core dumps if the app has used other third-party libs depends on SSL.

Since we can't remove all the third-party which might still be using std::threads, we sometimes need to disable SSL in Photon.

The new ENABLE_TLS option will only affect RPC client and HTTP client, and can defaults to ON.

Another option is not to add this option, but to change RPC client API. If not passing a TLSContext*, the TLS stream will not be initialized, so the SSL global init will not be called.

jiangdongzi commented 8 months ago

IMO TLS is misleading. Developers may think it means thread local storage

lihuiba commented 8 months ago

IMO TLS is misleading. Developers may think it means thread local storage

Yes, I believe so. I once had such confusion. Is there any suggestions?