alibaba / Sentinel

A powerful flow control component enabling reliability, resilience and monitoring for microservices. (面向云原生微服务的高可用流控防护组件)
https://sentinelguard.io/
Apache License 2.0
22.31k stars 8k forks source link

Micrometer Observation Support #3235

Open marcingrzejszczak opened 11 months ago

marcingrzejszczak commented 11 months ago

Issue Description

Type: feature request

Describe what feature you want

I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with @shakuzen and @jonatan-ivanov).

Micrometer Observation is part of the Micrometer 1.10 release and Micrometer Tracing is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit).

I was curious if there's interest in adding Micrometer Observation support so that except for metrics, spans could be created and tracing context propagation could happen too. Via Micrometer Tracing one can use OpenTelemetry or OpenZipkin Brave Tracer, but with the handler mechanism the possibilities are endless :)

Describe your initial design (if present)

We would need to find egress and ingress points (getting messages / requests, sending messages / requests) and instrument those using Micrometer Observation API.

Additional context

There's already quite a few projects that we support https://github.com/micrometer-metrics/micrometer/blob/main/docs/modules/ROOT/pages/observation/projects.adoc

sczyh30 commented 11 months ago

cc @LearningGp @karl-sy