search

alibaba / Sentinel

A powerful flow control component enabling reliability, resilience and monitoring for microservices. (面向云原生微服务的高可用流控防护组件)
https://sentinelguard.io/
Apache License 2.0
22.45k stars 8.04k forks source link

MetricNode#toFatString 时间转换影响性能 #3463

Open brucelwl opened 1 month ago

brucelwl commented 1 month ago

https://github.com/alibaba/Sentinel/blob/195150bc745927429e9f14f501907310b46d702f/sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/MetricNode.java#L213-L230

214行, 每次都创建新的SimpleDateFormat影响性能, 改成java8的时间吧

manojks1999 commented 1 month ago

@brucelwl , I have made a PR please check this and let me know if any changes.

Thanks

brucelwl commented 1 month ago

@manojks1999 评论了,你看下

manojks1999 commented 4 weeks ago

@brucelwl I could not see any comment in PR and even in code too.

brucelwl commented 4 weeks ago

@manojks1999 现在再看下