alibaba / SmartEngine

SmartEngine is a lightweight business orchestration engine.
Apache License 2.0
760 stars 216 forks source link

fix parallel gateway threadpool npe #21

Closed yfcchilly closed 4 years ago

yfcchilly commented 4 years ago

resolve issue-19

  1. fix parallel gateway threadpool npe
  2. InstanceUtil npe fix
  3. ConcurrentModificationException fix
CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

vavi commented 4 years ago

感谢 pr, 其他地方我都看明白了,但是 反射取InheritableThreadLocal 的field,我感觉有点hack。 另外,我简单走读了下代码,我看到PersisterSession 的实现不是线程安全的,我先把这个问题修复下:

private Map<String, ProcessInstance> processInstances = new HashMap<String, ProcessInstance>(4);

其他代码我先合进来,反射的代码我们再沟通下? 你有IM? 可以先加下我的wechat。