alibaba / SmartEngine

SmartEngine is a lightweight business orchestration engine.
Apache License 2.0
768 stars 219 forks source link

DefaultDeploymentCommandService#updateDeployment does not update version column of se_deployment_instance #50

Closed JoshuaJeme closed 3 years ago

JoshuaJeme commented 3 years ago

DeploymentInstance creation use version parsed from processDefinitionContent com.alibaba.smart.framework.engine.service.command.impl.DefaultDeploymentCommandService#createDeployment .

But while updating DeploymentInstance, it ignored the version from processDefinitionContent, which break the consistency of version column of se_deployment_instance and the version in process_definition_content.

vavi commented 3 years ago

As with offline communication, it is not recommended to update the version when the process_definition is updated. The version filed should be unchangeable after created。