search

alibaba / TProfiler

TProfiler是一个可以在生产环境长期使用的性能分析工具
GNU General Public License v2.0
2.38k stars 923 forks source link

Add unit test for ProfTransformer and ProfFilter #12

Closed ikarishinjieva closed 11 years ago

ikarishinjieva commented 11 years ago

Hi, I've added unit test for ProfTransformer and ProfFilter. And some code changes are made to make the code testable. Could you please pull this changes?

BTW: found that DailyRollingFileWriter is coupled with MethodCache, and it's hard to make unit test without 'Manager.METHOD_LOG_PATH = "test.log"'. Could we use Log4J instead?

jlusdy commented 11 years ago

@ikarishinjieva Thank you very much for submitting pull requests. We can not use Log4J, because we need to reduce dependence as much as possible.

ikarishinjieva commented 11 years ago

@jlusdy Noted with thanks. And this pull request has no relation with Log4J, will you merge this for unit test?

jlusdy commented 11 years ago

@ikarishinjieva We hope the code is stable(Although it looks ugly), your unit test can exist as a branch. What do you think?

ikarishinjieva commented 11 years ago

@jlusdy Thanks. I was planning to make some unit test and then make some code improvement. Then I will keep it as a fork. Thank you.