search

alibaba / ai-matrix

To make it easy to benchmark AI accelerators
Other
179 stars 79 forks source link

DIEN implementation is not aligned with DIEN paper for some reason #103

Open andrei-kochin opened 2 years ago

andrei-kochin commented 2 years ago

Hello,

Could you please kindly clarify the reason in 'u_t' calculation in DIEN model? https://github.com/alibaba/ai-matrix/blob/f7e1d7788c03e01eea915ff2bcad10103dcb529e/macro_benchmark/DIEN/script/utils.py#L217

According to DIEN paper it should be u_t =a_t*u_t and in your implementation it is u_t = (1.0 - a_t) * u_t

Looking forward for your reply.

Thank you!

jane-intel commented 2 years ago

Paper: https://arxiv.org/pdf/1809.03672.pdf

Formulas 11-12: image

andrei-kochin commented 2 years ago

@rabbitwayne, @xulingjie @madeye @parallelo @ could you please help us to comment on that?