search

alibaba / alibaba-rsocket-broker

Alibaba RSocket Broker: Mesh, Streaming & IoT
https://alibroker.info
Apache License 2.0
761 stars 167 forks source link

Modify code with refactors #229

Open francestang1117 opened 1 year ago

francestang1117 commented 1 year ago

Hi, I refactored some code. Hope you could check it. Thank you.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

linux-china commented 1 year ago

@francestang1117 是不是 RSocketEncodingFacade.getInstance();更好一些？ 

 - protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance();
 + protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance(new RSocketEncodingFacadeImpl());
francestang1117 commented 1 year ago

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

linux-china commented 1 year ago

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

好的，我看一下这个问题，看能否更好地修复一下。