alibaba / fish-redux

An assembled flutter application framework.
https://github.com/alibaba/fish-redux
Apache License 2.0
7.33k stars 843 forks source link

Fixed Page class name duplication #642

Closed SystemTce closed 4 years ago

SystemTce commented 4 years ago

Fixed Page class name duplication

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-io commented 4 years ago

Codecov Report

Merging #642 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   52.81%   52.81%           
=======================================
  Files          54       54           
  Lines        1352     1352           
=======================================
  Hits          714      714           
  Misses        638      638           
Impacted Files Coverage Δ
...ib/src/redux_component_mixin/keep_alive_mixin.dart 0.00% <ø> (ø)
..._component_mixin/single_ticker_provider_mixin.dart 0.00% <ø> (ø)
...c/redux_component_mixin/ticker_provider_mixin.dart 0.00% <ø> (ø)
...omponent_mixin/widgets_binding_observer_mixin.dart 0.00% <ø> (ø)
lib/src/redux_routes/page_routes.dart 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5b7376...4b34778. Read the comment docs.

dddrop commented 4 years ago

638

zjuwjf commented 4 years ago

Thanks!