alibaba / formily

📱🚀 🧩 Cross Device & High Performance Normal Form/Dynamic(JSON Schema) Form/Form Builder -- Support React/React Native/Vue 2/Vue 3
https://formilyjs.org/
MIT License
11.26k stars 1.46k forks source link

fix(vue): decorator event props not work in vue2 #3884

Closed MeetzhDing closed 1 year ago

MeetzhDing commented 1 year ago

Before submitting a pull request, please make sure the following is done...

Please do not delete the above content


What have you changed?

fix https://github.com/alibaba/formily/issues/3883

By the way, all build/test work failed in my computer, it seems was a monorepo problem, but i don't know how to slove it.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

janryWang commented 1 year ago

你需要先全量构建才能跑起来,还有node环境,最好用12

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1e62b24) 96.59% compared to head (f1b7394) 96.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## formily_next #3884 +/- ## ============================================= Coverage 96.59% 96.60% ============================================= Files 152 152 Lines 6695 6708 +13 Branches 1869 1877 +8 ============================================= + Hits 6467 6480 +13 Misses 200 200 Partials 28 28 ``` | [Impacted Files](https://app.codecov.io/gh/alibaba/formily/pull/3884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) | Coverage Δ | | |---|---|---| | [packages/vue/src/components/ReactiveField.ts](https://app.codecov.io/gh/alibaba/formily/pull/3884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-cGFja2FnZXMvdnVlL3NyYy9jb21wb25lbnRzL1JlYWN0aXZlRmllbGQudHM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MeetzhDing commented 1 year ago

@janryWang please check this pr again. all test (include new one) pass .

Can I get a milestone about this fix?