alibaba / formily

📱🚀 🧩 Cross Device & High Performance Normal Form/Dynamic(JSON Schema) Form/Form Builder -- Support React/React Native/Vue 2/Vue 3
https://formilyjs.org/
MIT License
11.26k stars 1.46k forks source link

fix(core): @types/node pollution #3944

Closed Faithfinder closed 11 months ago

Faithfinder commented 1 year ago

Before submitting a pull request, please make sure the following is done...

Please do not delete the above content


What have you changed?

@formily/core package was bringing in and polluting the global environment with @types/node. This fixes it, you'll notice no more /// <reference types="node" /> at the top of packages/core/esm/types.d.ts after build.

image

Upgrade to rollup plugin, because the project refused to build under the old version for me.

Fixes #3985

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (8861ef5) 99.55% compared to head (02f0164) 99.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## formily_next #3944 +/- ## ============================================= Coverage 99.55% 99.55% ============================================= Files 152 152 Lines 6709 6709 Branches 1876 1876 ============================================= Hits 6679 6679 - Misses 29 30 +1 + Partials 1 0 -1 ``` | [Files](https://app.codecov.io/gh/alibaba/formily/pull/3944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) | Coverage Δ | | |---|---|---| | [packages/core/src/types.ts](https://app.codecov.io/gh/alibaba/formily/pull/3944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-cGFja2FnZXMvY29yZS9zcmMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/alibaba/formily/pull/3944/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Faithfinder commented 1 year ago

Not sure what's up with the Compressed Size workflow. Seems like the error is entirely unrelated to changes?

Faithfinder commented 1 year ago

Ok, no idea what's up. Help, please.