alibaba / hooks

A high-quality & reliable React Hooks library. https://ahooks.pages.dev/
https://ahooks.js.org/
MIT License
14.02k stars 2.71k forks source link

fireEvent 的问题 #2020

Closed DomeSy closed 1 year ago

DomeSy commented 1 year ago

在useHover的单元测试中,使用fireEvent.mouseOver

image

但实际上第二个参数并没有执行,就算 expect(result.current).toBe(true); => 改为expect(result.current).toBe(“随便输”);单元测试也能通过,这种方式是不是存在问题

DomeSy commented 1 year ago

fireEvent 的第二个参数应该是可选项,不应该是fn吧,验证应该在fireEvent之后执行吧~

miracles1919 commented 1 year ago

你说的是对的,欢迎 PR

DomeSy commented 1 year ago

好的,已提交PR

crazylxr commented 1 year ago

已合并