alibaba / innodb-java-reader

A library and command-line tool to access MySQL InnoDB data file directly in Java
Apache License 2.0
462 stars 115 forks source link

Update testRangeQueryByPrimaryKeyNegative assertion logic #38

Closed shunfan-shao closed 2 years ago

shunfan-shao commented 2 years ago

During the time I tried to examine the flakiness of the project, I noticed that testing behavior of testRangeQueryByPrimaryKeyNegative can be enhanced using existing functionalities.

I think even though the exceptions have been caught during invocation, we can use the return value to determine the correctness instead of simply calling the function.

Would it be better to use some enum values to represent the status? Or examine the log file.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: shunfan-shao
:x: Shao


Shao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.