Closed shunfan-shao closed 2 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@shunfan-shao Thanks for your contribution!
This commit updates the testing behavior of
com.alibaba.innodb.java.reader.InnodbReaderBootstrapTest.testRangeQueryByPrimaryKeyNegative
I think the original test would not really guarantee anything. I changed the behavior so that it uses the return result of the setup function. In this way, the test is able to at least determine whether the program can run with the given arguments.
It tests for invalid input arguments and is supposed to throw an exception, which is caught during the program thus cannot be checked during test. I have two proposal for better testing behaviors.