alibaba / libgrape-lite

🍇 A C++ library for parallel graph processing (GRAPE) 🍇
https://alibaba.github.io/libgrape-lite/
Apache License 2.0
397 stars 92 forks source link

Small fix of vertex map #134

Closed songqing closed 1 year ago

songqing commented 1 year ago

What do these changes do?

When running the test of vertex map, I encountered a small problem with the script, see

g1

Besides, some small code optimization of vertex map is submitted.

Related issue number

Fixes

codecov-commenter commented 1 year ago

Codecov Report

Merging #134 (91c9a57) into master (4aea35a) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/alibaba/libgrape-lite/pull/134/graphs/tree.svg?width=650&height=150&src=pr&token=Jwwd96nVmz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba)](https://codecov.io/gh/alibaba/libgrape-lite/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) ```diff @@ Coverage Diff @@ ## master #134 +/- ## ========================================== - Coverage 70.03% 70.00% -0.04% ========================================== Files 64 64 Lines 5726 5720 -6 ========================================== - Hits 4010 4004 -6 Misses 1716 1716 ``` | Flag | Coverage Δ | | |---|---|---| | app_tests | `70.00% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/alibaba/libgrape-lite/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) | Coverage Δ | | |---|---|---| | [grape/vertex\_map/global\_vertex\_map.h](https://codecov.io/gh/alibaba/libgrape-lite/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-Z3JhcGUvdmVydGV4X21hcC9nbG9iYWxfdmVydGV4X21hcC5o) | `62.60% <ø> (-0.31%)` | :arrow_down: | | [grape/vertex\_map/vertex\_map\_base.h](https://codecov.io/gh/alibaba/libgrape-lite/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-Z3JhcGUvdmVydGV4X21hcC92ZXJ0ZXhfbWFwX2Jhc2UuaA==) | `100.00% <ø> (ø)` | | | [tests/vertex\_map\_tests.cc](https://codecov.io/gh/alibaba/libgrape-lite/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-dGVzdHMvdmVydGV4X21hcF90ZXN0cy5jYw==) | `89.69% <ø> (-0.51%)` | :arrow_down: | | [grape/vertex\_map/local\_vertex\_map.h](https://codecov.io/gh/alibaba/libgrape-lite/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-Z3JhcGUvdmVydGV4X21hcC9sb2NhbF92ZXJ0ZXhfbWFwLmg=) | `60.48% <100.00%> (ø)` | |
DevBuddyConnor commented 1 year ago

[AI Review] This comment is generated by an AI model (GPT-3.5-turbo).

Based on the provided patch, it seems that the changes are related to the VertexMap in the Grape library. The changes include modifying the way the vertices are mapped and converting the vertex ids with the help of mappings. Additionally, there are changes in the way the threads are created for sending and receiving messages and modifying the way the global and local vertex maps are built.

Without more context on the purpose of these changes, it is difficult to determine if they are correct or not. However, the changes seem to be consistent with the functionality of the Grape library. Therefore, it is recommended to review the purpose of these changes and test them thoroughly before merging the pull request.