Closed mroldx closed 1 day ago
Thanks for your this PR. :pray:
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API
, Add new configuration
, Change default value of configuration
.
If so, please add or update documents(markdown type) in docs/next/
for repository nacos-group/nacos-group.github.io
感谢您提交的PR。 :pray:
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API
、新增配置参数
、修改默认配置
等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/
目录下添加或更新文档(markdown格式)。
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.16%. Comparing base (
aeaaded
) to head (e3069dc
).
$\color{red}{FAILURE}$ DETAILS ✅ - docker: success ❌ - deploy (standalone & cluster & standalone_auth): failure ❌ - e2e-java-test (standalone & cluster & standalone_auth): skipped ❌ - e2e-go-test (standalone & cluster): skipped ❌ - e2e-cpp-test (standalone & cluster): skipped ❌ - e2e-csharp-test (standalone & cluster): skipped ❌ - e2e-nodejs-test (standalone & cluster): skipped ❌ - e2e-python-test (standalone & cluster): skipped ✅ - clean (standalone & cluster & standalone_auth): success
There are some e2e error in this pr and PR #12866 has fixed this problem.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Remove excess commas from mysql-schema.sql
Brief changelog
publish_type
varchar(50) DEFAULT 'formal' COMMENT 'publish type gray or formal',, -----》publish_type
varchar(50) DEFAULT 'formal' COMMENT 'publish type gray or formal', Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.