search

alibaba / nacos

an easy-to-use dynamic service discovery, configuration and service management platform for building cloud native applications.
https://nacos.io
Apache License 2.0
30.21k stars 12.83k forks source link

JAVA_HOME not found error message should remove "We need java(x64)" since arm64 is already supported from 1.4.1 #5073

Closed ensean closed 3 years ago

ensean commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

Expected behavior A clear and concise description of what you expected to happen.

Acutally behavior A clear and concise description of what you actually to happen.

How to Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

ensean commented 3 years ago

image

realJackSun commented 3 years ago

看起来是你的java版本装的不对，或者java环境变量没有配置。

ensean commented 3 years ago

@JackSun-Developer 我想表达的是1.4.1版本已经支持在Java(arm64)环境运行了，是否可以考虑把报错提示里的”(x64)“ 移出。

KomachiSion commented 3 years ago

因为还有人可能会使用x86版本的 所以提示应该还是必要的。

只是提示不影响你使用

ensean commented 3 years ago

因为还有人可能会使用x86版本的 所以提示应该还是必要的。

只是提示不影响你使用

这会给人错误信息以为nacos只支持x64 Java?

KomachiSion commented 3 years ago

我们无法保证32位java和系统是否能够运行出正确的结果，或许只是能够启动但运行结果是有问题的（比如涉及到一些位运算的时候）。为此我们统一使用x64的Java，并显示提示。