alibaba / nacos

an easy-to-use dynamic service discovery, configuration and service management platform for building cloud native applications.
https://nacos.io
Apache License 2.0
30.24k stars 12.84k forks source link

make nacos-client sdk remove prometheus dependency and metrics with other way. #8354

Open xuminwlt opened 2 years ago

xuminwlt commented 2 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

提一个实际应用中碰到的一个小问题,nacos-client依赖了一个较低的prometheus版本,而且非可选,作为核心客户端sdk做到尽可能轻量级的依赖,或者一个Default实现,JMX等,如果需要prometheus,则由adapter或者另一个依赖完成,对sdk的依赖规范来讲,要多一次依赖去除和更新版本的引入,无法精简,期待一个精简的nacos-SDK。

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

CherishCai commented 2 years ago

很久前同样遇到,0.5.0 实在太低了,也只能自己指定了更高的版本覆盖它。

stone-98 commented 2 years ago

@KomachiSion Can I take a stab at solving the problem?

stone-98 commented 2 years ago

我了解了相关功能,引入prometheus的目的是为了给用户提供扩展的能力,但是如果用户不使用这个能力,我觉得引入prometheus的依赖是多余的,我们可以基于nacos插件的机制,默认对这些监控指标不进行处理,当用户引入相应的插件之后,基于插件的机制再对这些指标进行相应的处理。我现在可以对它进行实现吗?或者说需要一个更详细的设计文档呢?

Lucius7boy commented 2 years ago

i want to learn what should i do

NooBMaster1412 commented 2 years ago

I want to learn from all of you bro,

Lucius7boy commented 2 years ago

Oh me too I want to learn

On Fri, Aug 5, 2022, 10:04 Nano @.***> wrote:

I want to learn from all of you bro,

— Reply to this email directly, view it on GitHub https://github.com/alibaba/nacos/issues/8354#issuecomment-1206219632, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2IYCE4FEKPAERLQKM53THTVXTKKHANCNFSM5VXMA6GA . You are receiving this because you commented.Message ID: @.***>

Tafalkamis commented 2 years ago

I need to recover my Microsoft account and this is the email associated with it

Tafalkamis commented 2 years ago

I can't access my account because of this Microsoft Authenticator app

KomachiSion commented 2 years ago

我了解了相关功能,引入prometheus的目的是为了给用户提供扩展的能力,但是如果用户不使用这个能力,我觉得引入prometheus的依赖是多余的,我们可以基于nacos插件的机制,默认对这些监控指标不进行处理,当用户引入相应的插件之后,基于插件的机制再对这些指标进行相应的处理。我现在可以对它进行实现吗?或者说需要一个更详细的设计文档呢?

可以先出一个设计文档,如果设计的方案没有太大问题,就可以动手了。