Closed j4ckstraw closed 1 year ago
Patch coverage has no change and project coverage change: +0.04
:tada:
Comparison is base (
c9bc043
) 32.21% compared to head (fba9ac3
) 32.26%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Can you keep the backward compatibiliy by keeping the master taint/selector?
This can be more friendly for users ugprading from 1.18
As far as I know, before 1.18 the label
node-role.kubernetes.io/control-plane
is also exist.
The label
node-role.kubernetes.io/master
is deprecated after kubernetes 1.18 by default. changenode-role.kubernetes.io/master
tonode-role.kubernetes.io/control-plane
refer: https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-master-taint
fix #215