search

alibaba / open-local

cloud-native local storage management system for stateful workload, low-latency with simplicity
Apache License 2.0
460 stars 81 forks source link

change node-role label selector #216

Closed j4ckstraw closed 1 year ago

j4ckstraw commented 1 year ago

The label node-role.kubernetes.io/master is deprecated after kubernetes 1.18 by default. change node-role.kubernetes.io/master to node-role.kubernetes.io/control-plane

refer: https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-master-taint

fix #215

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04 :tada:

Comparison is base (c9bc043) 32.21% compared to head (fba9ac3) 32.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================== + Coverage 32.21% 32.26% +0.04% ========================================== Files 41 41 Lines 6354 6354 ========================================== + Hits 2047 2050 +3 + Misses 4018 4016 -2 + Partials 289 288 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `32.26% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/alibaba/open-local/pull/216/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

peter-wangxu commented 1 year ago

Can you keep the backward compatibiliy by keeping the master taint/selector?

This can be more friendly for users ugprading from 1.18

j4ckstraw commented 1 year ago

As far as I know, before 1.18 the label node-role.kubernetes.io/control-plane is also exist.