Closed dongjiang1989 closed 9 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
4e7d041
) 32.42% compared to head (695264a
) 32.38%.
Files | Patch % | Lines |
---|---|---|
pkg/agent/discovery/device.go | 0.00% | 1 Missing :warning: |
pkg/agent/discovery/mountpoint.go | 0.00% | 1 Missing :warning: |
pkg/csi/nodeutils.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@peter-wangxu addressed comments, please review :)
LGTM
Go 1.16 deprecated several
io/ioutil
functions.ioutil.ReadFile
->os.ReadFile
ioutil.ReadAll
->io.ReadAll
ioutil.ReadDir
->os.ReadDir
Deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.
ref: https://pkg.go.dev/io/ioutil