Closed dongjiang1989 closed 9 months ago
Attention: 15 lines
in your changes are missing coverage. Please review.
Comparison is base (
3f84fda
) 32.31% compared to head (3b4688a
) 32.24%.
Files | Patch % | Lines |
---|---|---|
pkg/csi/nodeserver.go | 0.00% | 15 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@peter-wangxu addressed comments, please review :)
BTW, any reason to set this limit, do you meet any limitation on lvm/linux?
BTW, any reason to set this limit, do you meet any limitation on lvm/linux?
Setting a reasonable number of volumes is related to Node disk pressure and Pod balanced deployment. In my case: lvm2 on aws ebs
@peter-wangxu Please re-check
@peter-wangxu Please release patch version 🤔️
I have not verify this version in production env, do you mind a pre-relase for current version?
I have not verify this version in production env, do you mind a pre-relase for current version?
Yes. Pre-release versions are helpful to me
This PR adds support for returning max volume limit in CSI NodeGetInfo call, It returns MaxVolumesPerNode in CSINodeGetInfo response, which defaults to 64, This can be configured via
MAX_VOLUMES_PERNODE
from ENV config.