search

alibaba / rax

🐰 Rax is a progressive framework for building universal application. https://rax.js.org
Other
7.99k stars 627 forks source link

fix(rax): add lacked input argument of getDerivedStateFromError (fix #2211) #2212

Closed Clarence-pan closed 3 years ago

Clarence-pan commented 3 years ago

Fix bug: The input argument of getDerivedStateFromError of class component is missing #2211

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

SoloJiang commented 3 years ago

可以加一下单测

Clarence-pan commented 3 years ago

可以加一下单测

@SoloJiang 加了，详见 83795c51067af94d6a5a7e7d797a408e1b1584bb