alibaba / sentinel-golang

Sentinel Go enables reliability and resiliency for Go microservices
https://sentinelguard.io/
Apache License 2.0
2.77k stars 434 forks source link

[RFC] Support monitoring (dry-run) mode #366

Open sczyh30 opened 3 years ago

sczyh30 commented 3 years ago

Issue Description

Type: feature request

Describe what feature you want

RFC: Support monitoring (dry-run) mode. In monitoring mode, Sentinel won't actually block the requests, but only record the relevant metrics (for observation). This could be useful when users need to verify whether the rules are appropriate.

louyuting commented 3 years ago

From my perspective, maybe a global config for monitoring mode is enough?

sczyh30 commented 3 years ago

Maybe two levels are needed: global level and rule level. A new kind of metric (like "should block") is required for monitoring mode. More discussions are needed for details (e.g. event propagation, metric logs).

ansiz commented 3 years ago

I think monitoring mode is necessary. For production safety, we usually want to configure a monitoring mode rule first