Open sunyucheng opened 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.08
:tada:
Comparison is base (
0807185
) 53.17% compared to head (5d210df
) 53.25%.:exclamation: Current head 5d210df differs from pull request most recent head 0e75426. Consider uploading reports for the commit 0e75426 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @binbin0325 @sczyh30, looking forward to your reply.
Hi @sczyh30 @binbin0325, if there are no doubts, we look forward to the adoption of PR
Hi @sczyh30 @binbin0325, looking forward to your reply
Hi @sczyh30 @binbin0325, looking forward to your reply
Describe what this PR does / why we need it
fix getProcessCpuStat return value (in percentage) breaks compatibility.
Does this pull request fix one issue?
Fix https://github.com/alibaba/sentinel-golang/issues/539
Describe how you did it
fix the bug that the CPU usage from getProcessCpuStat was changed to percentage value (i.e. 0-100), which breaks compatibility and affects system adaptive rules.
Describe how to verify it
Added a unit test
func TestRetrieveAndUpdateCpuStatReturnValueRange(t *testing.T)
Special notes for reviews