search

alibaba / sentinel-golang

Sentinel Go enables reliability and resiliency for Go microservices
https://sentinelguard.io/
Apache License 2.0
2.77k stars 435 forks source link

Potential import collision: import path should be "github.com/etcd-io/etcd", not "github.com/coreos/etcd" #584

Open HappyHacker123 opened 2 weeks ago

HappyHacker123 commented 2 weeks ago

Issue Description

This project alibaba/sentinel-golang depends on github.com/etcd-io/etcd which already opted into module and redirects(or rename) its import path from "github.com/coreos/etcd" to "github.com/etcd-io/etcd" . You import github.com/etcd-io/etcd through the old path "github.com/coreos/etcd" . But when downstream module users try to get github.com/etcd-io/etcd through the indirect path "github.com/coreos/etcd" from alibaba/sentinel-golang, they will easily get build errors:

> go get: github.com/coreos/etcd : parsing go.mod:
> module declares its path as: github.com/etcd-io/etcd
> but was required as: github.com/coreos/etcd

Describe what feature you want

Replace all the old import paths, replace "github.com/coreos/etcd" with "github.com/etcd-io/etcd.

binbin0325 commented 2 weeks ago

Can you submit a pr to fix it

578223592 commented 2 weeks ago

Issue Description

This project alibaba/sentinel-golang depends on github.com/etcd-io/etcd which already opted into module and redirects(or rename) its import path from "github.com/coreos/etcd" to "github.com/etcd-io/etcd" . You import github.com/etcd-io/etcd through the old path "github.com/coreos/etcd" . But when downstream module users try to get github.com/etcd-io/etcd through the indirect path "github.com/coreos/etcd" from alibaba/sentinel-golang, they will easily get build errors:

go get: github.com/coreos/etcd : parsing go.mod: module declares its path as: github.com/etcd-io/etcd but was required as: github.com/coreos/etcd

Describe what feature you want

Replace all the old import paths, replace "github.com/coreos/etcd" with "github.com/etcd-io/etcd.

@binbin0325 @HappyHacker123 maybe it is better to wait the pr:https://github.com/alibaba/sentinel-golang/pull/582