search

alibaba / spring-cloud-alibaba

Spring Cloud Alibaba provides a one-stop solution for application development for the distributed solutions of Alibaba middleware.
https://sca.aliyun.com
Apache License 2.0
27.96k stars 8.34k forks source link

Adjust governance module component naming discussion #3238

Closed steverao closed 8 months ago

steverao commented 1 year ago

Background

The microservices governance capability built by the community was released in version 2.2.10-RC1. For related content, please refer to:

We named the relevant modules at that time:

We did them according to following rule: The Spring Cloud Alibaba community has been proposed and voted by the Community Steering Committee Management Committee. From 2023, the new module naming rules of the community will follow: spring-cloud-starter-(component's company name)-(component name)-function name(subfunction name) Name the module, where the content of () indicates that it is not necessary and can be omitted, and the sub-function name is at most one level. But we will develop some new abilities in the future, such as mTLS, Outlier instance removal and so on, I think we need to contain them in our above module, because, if we create new module, relevant abilities will be very scattered, not concentrated. But inclusiveness of above module names is not high, generalization is not enough.

New Plan

I think following naming of relevant modules is more suitable.

In the future, we can put mTLS and some other security abilities into spring-cloud-starter-alibaba-governance-security, and put Outlier instance removal and some other traffic management abilities into spring-cloud-starter-alibaba-governance-traffic.

yuluo-yx commented 1 year ago

I agree with you!

qakqs commented 1 year ago

I agree with you!

qakqs commented 1 year ago

Can it be named according to the concept and specification of DDD？

steverao commented 1 year ago

Can it be named according to the concept and specification of DDD？

Please explain your thinking and reason, it's hard to modify naming rule. Because, it was proposed and voted by the Community Steering Committee Management Committee.

ruansheng8 commented 1 year ago

Is there a plan to further decompose the traffic module into sub-modules, given that it encompasses multiple functionalities such as routing, rate limiting, circuit breaking, and retrying?

steverao commented 1 year ago

Is there a plan to further decompose the traffic module into sub-modules, given that it encompasses multiple functionalities such as routing, rate limiting, circuit breaking, and retrying?

Rate limiting and circuit breaking will be contained in modules of Sentinel. Others that if we plan to develop will be contained in module of traffic directly.

github-actions[bot] commented 8 months ago

This issue has been open 30 days with no activity. This will be closed in 7 days.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity.If you think this should still be open, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up. Thank you for your interest and contribution to the Sping Cloud Alibaba Community.