Closed Happy-26 closed 1 week ago
在 com.alibaba.cloud.nacos.registry.NacosServiceRegistry 类中,如果注册失败会打印错误日志,此时会将nacos的用户名和密码明文打印出来。
com.alibaba.cloud.nacos.registry.NacosServiceRegistry
@Override public void register(Registration registration) { if (StringUtils.isEmpty(registration.getServiceId())) { log.warn("No service to register for nacos client..."); return; } NamingService namingService = namingService(); String serviceId = registration.getServiceId(); String group = nacosDiscoveryProperties.getGroup(); Instance instance = getNacosInstanceFromRegistration(registration); try { namingService.registerInstance(serviceId, group, instance); log.info("nacos registry, {} {} {}:{} register finished", group, serviceId, instance.getIp(), instance.getPort()); } catch (Exception e) { if (nacosDiscoveryProperties.isFailFast()) { // 此时会将nacos的用户名和密码明文打印出来。 log.error("nacos registry, {} register failed...{},", serviceId, registration.toString(), e); rethrowRuntimeException(e); } else { log.warn("Failfast is false. {} register failed...{},", serviceId, registration.toString(), e); } } }
建议此处不打印敏感信息
I will fix it.
在
com.alibaba.cloud.nacos.registry.NacosServiceRegistry
类中,如果注册失败会打印错误日志,此时会将nacos的用户名和密码明文打印出来。建议此处不打印敏感信息