alibaba / tsar

Taobao System Activity Reporter
Apache License 2.0
2.48k stars 735 forks source link

parse_add_string #84

Closed guoyunliang closed 6 years ago

guoyunliang commented 7 years ago

if (var == NULL) { if (token) { strncpy(var, token, strlen(token)); } } else { if (token) { strcat(token, ","); strncat(token, var, strlen(var)); } if (token) { strncpy(var, token, strlen(token)); } } 上述代码中,var==NULL时,怎么还可以执行strncpy

kongjian commented 6 years ago

这是错误用法 目前代码走不到这个分支 但是需要修复