alibaba / virtual-environment

Route isolation with service sharing https://alibaba.github.io/virtual-environment/#/zh-cn/
MIT License
217 stars 39 forks source link

修复多 header 下 pattern 不生效的问题,并合并 vs 规则 #20

Closed cynial closed 4 years ago

cynial commented 4 years ago

看看这两个改动是否合适?#14

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


cylhuang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

linfan commented 4 years ago

实现有点问题,实际上Pattern的值不能直接用,需要将labelVal替换掉Pattern里面的某个占位符才是包含要匹配的目标环境名称的Pattern,然后作为Regex字段匹配的内容。先合并进来吧,后面我来补。