[Bug]: No rttvar in the argument of REC_METRICS_UPDATED in BBR.

alibaba / xquic

XQUIC Library released by Alibaba is a cross-platform implementation of QUIC and HTTP/3 protocol.

Apache License 2.0

1.65k stars 326 forks source link

[Bug]: No rttvar in the argument of REC_METRICS_UPDATED in BBR. #187

Closed osa-bm closed 1 year ago

osa-bm commented 2 years ago

The format "ctl_rttvar:%ui" exists in the argument of xqc_log_implement(), but ctl->ctl_rttvar is not specified in the argument. I think the output results are incorrect because the format and the number of arguments do not match.

https://github.com/alibaba/xquic/blob/8fab2f91a468dc9f37ba02cca14d032ca8f40353/src/common/xqc_log_event_callback.c#L417-L422

ruiqizhou commented 2 years ago

Thanks for reporting the bug. We would appreciate it if you would like to submit a PR to fix it