[Bug]: `xqc_build.sh` is ambiguous, and may cause unexpected compile failures

alibaba / xquic

XQUIC Library released by Alibaba is a cross-platform implementation of QUIC and HTTP/3 protocol.

Apache License 2.0

1.65k stars 326 forks source link

[Bug]: `xqc_build.sh` is ambiguous, and may cause unexpected compile failures #238

Open Luffbee opened 1 year ago

Luffbee commented 1 year ago

What happened?

The name of xqc_build.sh makes people think it's used to build (on any platform). Worse yet, IT MODIFIES CMakeList.txt even if it fails, which is hard to notice. Then the modified CMakeList.txt will cause compile failures later even if people find the right way to build.

Steps To Reproduce

run xqc_build.sh first, then follow README to build.

Relevant log output

No response

nixwl commented 6 months ago

Hello ! I had run xqc_build.sh first,then follow README to build, after I run xqc_build.sh , shell shows:

use default ssl path: /home/nixwl/desktop/xquic/third_party/boringssl ssl environment not exists

but when i run ./scripts/xquic_test.sh , i fails, this is the problem: -- Could NOT find SSL (missing: SSL_LIBRARY_STATIC CRYPTO_LIBRARY_STATIC)