Fix Bug in xqc_engine.c, Bug: Reinject unacked packet twice

alibaba / xquic

XQUIC Library released by Alibaba is a cross-platform implementation of QUIC and HTTP/3 protocol.

Apache License 2.0

1.64k stars 326 forks source link

Fix Bug in xqc_engine.c, Bug: Reinject unacked packet twice #360

Closed ShengtongZhu closed 7 months ago

ShengtongZhu commented 8 months ago

In xqc_conn_schedule_packets_to_paths, the unacked packets are reinjected. After that, they are reinjected again. So, those lines of code should be deleted.

CLAassistant commented 8 months ago

All committers have signed the CLA.

yangfurong commented 7 months ago

It is not a bug. Here, we try to reinject unacked packets immediately after they have been committed into the network. In xqc_conn_schedule_packets_to_paths, we can't do it as the packets are not sent yet (thus, they are not unacked).