Compile error when class contains std::unique_ptr<base>

[WeaveAche]

Search before asking

• [x] I searched the issues and found no similar issues.

What happened + What you expected to happen

Compilation error when a class contains std::unique_ptr but works fine otherwise. Expect to compile in both cases.

Reproduction way

base.hpp

#pragma once
#include <bits/stdc++.h>

struct base {
  virtual uint32_t get_struct_pack_id() const = 0;
  virtual std::string get_name() const = 0;
  static std::unique_ptr<base> deserialize(std::string &);
};

derived.hpp

#include <bits/stdc++.h>
#include "ylt/struct_pack.hpp"
#include "base.hpp"

struct derived : public base {
  std::unique_ptr<base> member;
  //std::string member;

  derived() = default;

  uint32_t get_struct_pack_id() const override;

  std::string get_name() const override {
      return "derived";
  }
};
STRUCT_PACK_REFL(derived, member);

common.cpp

#include "base.hpp"
#include "derived.hpp"
#include "ylt/struct_pack.hpp"

STRUCT_PACK_DERIVED_IMPL(base, derived)

std::unique_ptr<base> base::deserialize(std::string &serialized) {
    return struct_pack::deserialize_derived_class<base, derived>(serialized).value();
}

main.cpp

#include "base.hpp"
#include "derived.hpp"

int main() {
    derived d{};
    auto s = struct_pack::serialize<std::string>(d);
    auto n = base::deserialize(s);
}

Compiled with g++ main.cpp common.cpp -I yalantinglibs/include. The compilation fails when derived::member is std::unique_ptr<base> but works fine if it is anything else.

Anything else

No

Are you willing to submit a PR?

• [x] Yes I am willing to submit a PR!

[WeaveAche]

base is an empty struct here so the assertion on packer.hpp:419 fails. But since struct_pack already supports serializing std::unique_ptr<base> it should do it in this case too?

[WeaveAche]

Ok this happens because the STRUCT_PACK_DERIVED_IMPL macro needs to be in the header file.