alice-mkh / lightbird

Sunbird UI for Lightning on SeaMonkey
https://addons.mozilla.org/en-US/seamonkey/addon/lightbird/
13 stars 2 forks source link

Lightbird 0.5 opens password dialogs for each calendar on startup #22

Open malemburg opened 9 years ago

malemburg commented 9 years ago

After upgrading from 0.4 to 0.5, SeaMonkey starts with more than just one password dialog. Instead of just showing the single master password dialog, it also shows dialogs for every calendar registered in Lightning.

Reverting back to 0.4 makes the problem go away.

Would be nice to get this fixed. Thanks.

alice-mkh commented 9 years ago

Do you mean SeaMonkey start or the Calendar window start? In 0.5 I made it load calendar components on SM start instead of just when you open Calendar window.

malemburg commented 9 years ago

I meant SeaMonkey start.

The dialogs pop up because I have several remote calendars which need logins to be accessed - apparently because at the time the master password has not yet been entered.

alice-mkh commented 9 years ago

Confirmed. I have one remote password-protected calendar, and the dialog popped up two times. The second one was probably for mail. Interestingly, both of them were master password dialogs rather than a master password dialog and a "normal" login dialog.

adrianer commented 9 years ago

I experience the same bug - but since I have 9 calendars, I see 10 password dialogs at each start...

malemburg commented 8 years ago

Yes, all password dialogs are for the master password - even though I have set SeaMonkey to only ask for this once. Would it be possible to have the extension ask for the master password once and wait for entry before trying to query remote calendars ? Thanks.

malemburg commented 8 years ago

Installing this extension fixes the problem:

https://addons.mozilla.org/en-US/thunderbird/addon/startupmaster/

Perhaps there's something you could add from that extension to make those multiple popups disappear ?!

alice-mkh commented 8 years ago

In that case it would ask for the master password even if you do not use any remote calendars, but have master password set up for browser passwords.

alice-mkh commented 8 years ago

Not sure if it's possible to check that without too much hassle.

protist commented 8 years ago

Just wanted to mention that this had been a long-term issue for me with Thunderbird, even before I discovered Lightbird. I came across the same extension as @malemburg, which fixed it for me previously, and now also with Lightbird. My opinion is that it's a bug with Thunderbird/SeaMonkey, and nothing to do with Lightbird.

alice-mkh commented 8 years ago

Sure, but Lightbird makes it so that SeaMonkey is also affected. :) Usually you have the browser start up, and then somewhere later open the MailNews with the integrated calendar. It doesn't load the service from the start because it assumes that the MailNews is the only thing, like on Thunderbird. With Lightbird, the calendar service is loaded at the start (so that alerts work without opening MailNews), leading to this bug.

The problem with the solution is that just including similar code will break it in case you have no password-protected calendars.

protist commented 8 years ago

Oops! Sorry, I presumed this was the same for SeaMonkey as Thunderbird. My mistake!

alice-mkh commented 8 years ago

No problem. In fact I think that if SeaMonkey is configured to show MailNews on startup (or launched with -mail option), while having Lightning, but not Lightbird installed, the problem would be present.