alice-mkh / lightbird

Sunbird UI for Lightning on SeaMonkey
https://addons.mozilla.org/en-US/seamonkey/addon/lightbird/
13 stars 2 forks source link

Going to Today inflicts Messenger Window #5

Closed Hb- closed 11 years ago

Hb- commented 11 years ago

Steps to Reproduce:

  1. Open Messenger window
  2. Open Calendar window
  3. Go to Today by keyboard Alt+End, menu or clicking Today in the toolbar
  4. See the Messengers window title bar changing to "no start or due date".
alice-mkh commented 11 years ago

Unconfirmed. Is Lightning UI enabled?

Hb- commented 11 years ago

The start order of the components is important. Bugs happens only if Calendar is started before the Messenger.

To reproduce: Start Seamonkey 2.20 with the Browser window only

Now Ctrl+8 to start the Calendar (Lightning 2.5b2 and Lightbird 0.14)

Warning: Use of Mutation Events is deprecated. Use MutationObserver instead. Source File: chrome://calendar/content/calendar-views.xml Line: 62

Now Ctrl+2 to start the Messenger

Warning: Use of Mutation Events is deprecated. Use MutationObserver instead. Source File: chrome://calendar/content/widgets/calendar-widgets.xml Line: 306

Now Alt+Tab to bring the focus back to Calendar Now Alt+End to go to Today The bug appears now, the caption of the Messenger window changes to "no start or due date - Seamonkey"

Error: TypeError: tree is null Source File: chrome://calendar/content/calendar-common-sets.js Line: 897

Now close the Calendar window Now reopen the Calendar window Now Alt+End to go to Today The bug is gone, the caption of the Messenger window doesn't change any more. In the Error Console the same error "tree is null" as above is shown.

Lightbird preferences are: extensions.lightbird.disableLightningUI;true extensions.lightbird.tempNotification;false

What is the Lightning UI for? Does it allow to use the Calendar in a separate window and in a Messenger tab?

alice-mkh commented 11 years ago

The start order of the components is important. Bugs happens only if Calendar is started before the Messenger.

Error: TypeError: tree is null Source File: chrome://calendar/content/calendar-common-sets.js Line: 897

Oh. Then the reason is probably that the calendar scripts re-register tree to the one in Messenger, which is disabled.

Warning: Use of Mutation Events is deprecated. Use MutationObserver instead. Source File: chrome://calendar/content/widgets/calendar-widgets.xml Line: 306

That's not Lightbird bug, if anything. Happens with vanilla Lightning as well.

What is the Lightning UI for? Does it allow to use the Calendar in a separate window and in a Messenger tab?

Exactly. It's "Disable default Lightning UI" checkbox in Calendar preferences page. When it's false, Messenger calendar is there too.

alice-mkh commented 11 years ago

https://github.com/Exalm/lightbird/commit/57ea7c806ddfbf913afe95c285f3c7e968f1af18 If there will be regressions from this (aside of impossibility to re-enable Messenger UI), report it as a new issue.

Hb- commented 11 years ago

Where can I download the new version?

alice-mkh commented 11 years ago

https://dl.dropboxusercontent.com/u/36782044/lightbird-0.1.4-sm.xpi I haven't bumped the version yet, so it still says 0.1.4.

Edit: If you have Linux system somewhere, you can build it yourself. Just launch the build script.