Closed GranPC closed 10 years ago
Please revert the brightness commit and I'll merge it. :) I've redone the settings to allow customization (the actual customization UI is not there yet though), so it will not work again. It probably won't even merge automatically.
Done- out of curiosity, how are you gonna fix the brightness thing? This way looked pretty good to me.
There is nothing wrong with that way, it's just the fact that I have changed settings enough that this doesn't work anymore: the code is in different place. Basically, the settings rows aren't in the XML anymore and instead are generated in runtime. This allows to reorder them, delete them or add them in any moment.
Oh right! I'll see about putting it back in when you're done with the customization stuff :)
By the way, I forgot to add dependency to my settings option for the old style Recents. Should I do that in another commit or would it be better for you to just add it after merging?
Awesome!
Thanks for the help getting access to the internal APIs to build this :)
I've added the dependency, and also made the option should reboot toast as well. I'll do the brightness thing tomorrow, but the different way, since this one will fail with custom themes.
Just splitting these commits to make it less of a pain in the ass.