alice-mkh / tabletkat

True tablet UI for KitKat
http://repo.xposed.info/module/org.exalm.tabletkat
15 stars 5 forks source link

Some initial issues #8

Closed Fatal1ty93RUS closed 9 years ago

Fatal1ty93RUS commented 10 years ago
  1. Upon actually making the module work after a couple of reboots, if the device is in Landscape mode - the navbar buttons are invisible unless you rotate the device into portrait and back
  2. The notification icons are not being displayed in the unified navbar, which was the case even back on 4.0, just like in status bar
  3. Are there plans to expand the toggles? I remember having same amount of quick settings in the unified bar in some Custom ROMs as we have available for the quick settings panel today
  4. Is there a way to tie in not just the status/navbar but also affect the settings menu? Phab7 module doesn't get the job done sadly :/
  5. The recent menu is kind of offset to the left instead of being kinda centered on stock, like it's stickied to the navbar buttons
alice-mkh commented 10 years ago
  1. What ROM is that? I thought it was CM- and OmniROM-only issue.
  2. They are displayed there for me.
  3. Yes.
  4. Maybe, but only after getting the basic functionality to work on most ROMs.
  5. Yes. That's how it was since 3.0 all the way to 4.1. http://cdn.arstechnica.net/wp-content/uploads/2012/11/xoom-jb-home-screen.jpeg The centered recents in 4.2 is actually lack of tablet-optimized recents.
Pompitousofseth commented 10 years ago

Notifications don't show up on my nexus 7 2012. Everytime a button is pressed the nav bar flashes and the background moves. Also in the app drawer the nav bar mirrors the icons in portrait but then disappear. I know you don't have any way to test/replicate these error but if you can look into it that would be amazing because I have been waiting for someone to do this for a while.

Fatal1ty93RUS commented 10 years ago

@Exalm

  1. Stock 4.4.4 on Nexus 10
  2. Well, not for me. If I open the notification drawer - everything's fine, but I remember how in this unified bar when there was a notification - you could see the icons there. This is not the case here
  3. YAY!
  4. I meant to make the Settings app be affected and make it look this way -> http://i.imgur.com/uGGd7ba.png
  5. Oh ok, I thought it was a bug of some sorts
alice-mkh commented 10 years ago
  1. Interesting. Well, I developed it against 4.4.2 sources, I assume. I didn't know they are different enough to break this.
  2. So this is another breakage caused by 4.4.2→4.4.4 differences. And, I assume, source of many other missing method problems in CM and other ROMs.
  3. Yes, that's what I meant. In theory, this is pretty easy to do, but I want to get SystemUI functionality to work well first. You'll rather want one feature that works well than a bunch of features, all of which work poorly, won't you? ;)
alice-mkh commented 10 years ago

@Pompitousofseth Notifications don't show — do you mean "tickers" (the message that pops up, hiding clock, battery etc with itself) or notification icons to the left of the clock? As for the other problems, I can't understand anything there. :) What background moves? How app drawer emirrors icons (screenshot?), what disappears?

Fatal1ty93RUS commented 10 years ago

@Exalm

  1. and 2. Yeah, probably. There's like over 9000 changes between not even 4.4.4 and 4.4.2, but even between 4.4.3 and 4.4.4, you might tale a look at this http://www.androidpolice.com/2014/06/03/developer-changelog-comprehensive-list-of-all-7454-changes-between-4-4-2-kot49h-through-4-4-3-ktu84l/ So I guess you'll have a lot of work to do to rebase the module on 4.4.4 sources (or at least 4.4.3, since 4.4.4 is pretty minor compared to 4.4.3)
  2. Yeah, makes sense haha

Are you going to make a module post on XDA? Not that I have any trouble interacting with you here on Git, but still

alice-mkh commented 10 years ago

Or maybe ticker layout was silently removed between 4.4.2 and 4.4.4. I experienced a similar issue, when I tested it on high DPI, basically forcing it in tablet mode on a phone screen. The tickers didn't appear, but they correctly hid the notifications. However, as there are no tickers, they couldn't unhide the notifications. The problem was that the tablet ticker layout is present only for large screens. So I had to copy it to TabletKat and replace the system layout with it. If it was completely removed, the replacement will fail, and thus it will not work at all.

alice-mkh commented 10 years ago

@Fatal1ty93RUS Yes. I just don't have enough posts there, so it won't let me post any links. I don't think that a post with no links to Xposed repo and here will be very useful.

Fatal1ty93RUS commented 10 years ago

@Exalm OH! I almost forgot - I don't know if it's Xposed or the module issue, but somehow after installing v1.0.1 - Xposed still says there's an update available

alice-mkh commented 10 years ago

Umm, yes, that's a bug. I had forgotten to change the version in gradle.build before I pushed it to the repo. So it displays correctly, but when it checks for updates, it says that it's still 1.0. That's already fixed.

Fatal1ty93RUS commented 10 years ago

Okay. I'm excited for the future of this module! If there's any testing/help/screenies needed - feel free to message me, you can also find me on XDA if you need to at http://forum.xda-developers.com/member.php?u=4604975

P.S. Also - these are the notification icons in the unified bar I've been talking about, just as an example http://b2b.cbsimg.net/blogs/differences_notifications_tablet.png - to the left of the clock.

alice-mkh commented 10 years ago

Implemented 3 and 4, and Gran PC has made the 5 toggle-able. :)

Fatal1ty93RUS commented 10 years ago

YES!!! Is update available already?

alice-mkh commented 10 years ago

Nope. https://dl.dropboxusercontent.com/u/36782044/tabletkat-test8.apk Заодно перевел. :D

alice-mkh commented 10 years ago

It's not released yet because I want to fix some bugs before the release, and the quick settings aren't yet configurable. There is just a toggle to add a toggle to Wi-Fi row (thanks Gran PC for idea and WifiController class :)), and Bluetooth and Location rows now. However, I'm planning to add complete configuration, and back-end for that is already there, just no UI yet.

alice-mkh commented 9 years ago

So, all of the points of the issue are solved now, closing.