search

alice-mkh / tabletkat

True tablet UI for KitKat
http://repo.xposed.info/module/org.exalm.tabletkat
15 stars 5 forks source link

Add WiFi switch to settings pane #9

Closed GranPC closed 10 years ago

alice-mkh commented 10 years ago

Nice. I'll add an option for extended quick settings first, then I'll merge it, ok? :)

GranPC commented 10 years ago

Alrighty!

GranPC commented 10 years ago

Didn't notice I was still committing to the same branch.

Would you prefer if I moved those commits to another one?

alice-mkh commented 10 years ago

No, that's ok.

alice-mkh commented 10 years ago

Hmm, I don't quite understand what you are doing with the brightness icon. Can you explain it? :) And it has the same size as the others for me... Screenshot?

GranPC commented 10 years ago

When you attached the brightness controller, SystemUI changed the icon to a version they bundle, which is slightly lighter than the other icons (at least on my Nexus 7, running 4.4.2).

What I'm doing is revert the icon after attaching the controller. However after doing that, the icon looked smaller, so I upscaled it.

alice-mkh commented 10 years ago

Well, it changes when you toggle auto mode, so it will not work. So can you revert that (both commits) and instead open a bug? :)

GranPC commented 10 years ago

Oh crap, never noticed the icon changes.

GranPC commented 10 years ago

Reverted. I'm going to fix it proper in another branch.

alice-mkh commented 10 years ago

Thanks. I'm adding a proper infrastructure for custom settings now, which will allow complete customization (Show/hide rows and reorder them). There will be WiFi rows both with and without switch. I'll merge this manually, because it will require cherry-picking. :)

GranPC commented 10 years ago

Alrighty. Do you want me to move the other (non-settings) commits to another branch for easier merging?

alice-mkh commented 10 years ago

Yes, please. When I said no, there weren't so many commits. :)

GranPC commented 10 years ago

Copied them to #10

alice-mkh commented 10 years ago

I've merged Wi-Fi switch manually, so that it works with new settings. Well, it works. :) https://github.com/Exalm/tabletkat/commit/dce371450d72f85ae2a83d45a764ffc9d1aea467 Closing.