search

alice1017 / SelectMenu

SelectMenu is the input form to choose from menu by arrow keys.
MIT License
22 stars 10 forks source link

prompt_toolkit not required #1

Closed ErikBoesen closed 5 years ago

ErikBoesen commented 5 years ago

I had to install this manually. Seems like a mistake.

ErikBoesen commented 5 years ago

I'm happy to fix this, by the way.

alice1017 commented 5 years ago

@ErikBoesen Thank you for issue. SelectMenu imports the prompt_toolkit here. https://github.com/alice1017/SelectMenu/blob/master/selectmenu/core.py#L6 What do you mean?

ErikBoesen commented 5 years ago

I said the wrong thing. I meant that it doesn't seem to be installed as a dependency.

alice1017 commented 5 years ago

@ErikBoesen That makes sense. I wrote the install_require attribute in setup.py here. https://github.com/alice1017/SelectMenu/blob/master/setup.py#L21

Do you use setup.py for install? or another way?

$ python setup.py build install

If prompt_toolkit doesn't install, you can install manually by pip.

$ pip install -r requirements.txt

Please try.

ErikBoesen commented 5 years ago

I installed through pip. I already installed prompt-toolkit manually, but I don't think I should have to

alice1017 commented 5 years ago

@ErikBoesen Good! I will close this issue.