search

alicebob / miniredis

Pure Go Redis server for Go unittests
MIT License
3.09k stars 215 forks source link

redis: can't parse array/set/push #332

Closed mojixcoder closed 1 year ago

mojixcoder commented 1 year ago

I'm using this package for my redis tests with go-redis v9.

I get the following error:

cluster.go:1763: getting command info: redis: can't parse array/set/push reply: "$9440"

Anyone has had this issue before?

alicebob commented 1 year ago

On Tue, Jun 20, 2023 at 06:29:06AM -0700, Mojtaba Arezoumand wrote:

I'm using this package for my redis tests with go-redis v9.

I get the following error:

cluster.go:1763: getting command info: redis: can't parse array/set/push reply: "$9440"

Anyone has had this issue before?

Hi,

thanks for the issue. Do you happen to know if that's with the "new" response format (version 3)? Or can you make a small testcase?

mojixcoder commented 1 year ago

.

mojixcoder commented 1 year ago

On Tue, Jun 20, 2023 at 06:29:06AM -0700, Mojtaba Arezoumand wrote: I'm using this package for my redis tests with go-redis v9. I get the following error: cluster.go:1763: getting command info: redis: can't parse array/set/push reply: "$9440" Anyone has had this issue before? Hi, thanks for the issue. Do you happen to know if that's with the "new" response format (version 3)? Or can you make a small testcase?

Sorry I couldn’t understand what do you mean by v3?

Does this package has a v3? I only see v2

alicebob commented 1 year ago

On Tue, Jun 20, 2023 at 06:42:57AM -0700, Mojtaba Arezoumand wrote:

Sorry I couldn’t understand what do you mean by v3?

Redis itself has two versions of the redis protocol, version 2 and 3. Miniredis should support both, but I expect that the "version 3" version of the redis protocol isn't as well used so it might have som bugs. I'll have a look with the information you gave.

mojixcoder commented 1 year ago

I upgraded miniredis from v2.14.1 to v2.30.3 and it got fixed.

And yes I am using v3.

alicebob commented 1 year ago

On Tue, Jun 20, 2023 at 06:52:08AM -0700, Mojtaba Arezoumand wrote:

I upgraded miniredis from v2.14.1 to v2.30.3 and it got fixed.

Oh great! Thanks for letting me know.