search

alicebob / miniredis

Pure Go Redis server for Go unittests
MIT License
3.1k stars 217 forks source link

HRANDFIELD implementation #351

Closed sejin-P closed 11 months ago

sejin-P commented 11 months ago

Implementation of HRANDFIELD

alicebob commented 11 months ago

Thanks, looks good! Would it be possible to add a test in ./integration/ ? If not, also no problem.

Will have a better look in a few days.

sejin-P commented 11 months ago

@alicebob I added integration test case, but it had limit because testing random is pretty tricky.

alicebob commented 11 months ago

On Mon, Dec 04, 2023 at 02:45:24AM -0800, Sejin Park wrote:

@alicebob I added integration test case, but it had limit because testing random is pretty tricky.

Thanks! I know that, but the basic argument handling checks are already nice to have.

alicebob commented 11 months ago

Very nice. Merged, thanks!