search

alicebob / miniredis

Pure Go Redis server for Go unittests
MIT License
3.11k stars 217 forks source link

Add HEXPIRE support #382

Closed Daniel-W-Innes closed 1 month ago

Daniel-W-Innes commented 1 month ago

Add the HEXPIRE command by tracking ttls for each field in hashTtls.

alicebob commented 1 month ago

On Tue, Oct 08, 2024 at 09:09:03AM -0700, Daniel Innes wrote:

Add the HEXPIRE command by tracking ttls for each field in hashTtls.

Thanks for the PR!, I'll have a look soon. It will need some tests under ./integration/, which I'm happy to add if it's unclear how they work.

alicebob commented 1 month ago

hi @Daniel-W-Innes , any reason you closed this?

Daniel-W-Innes commented 1 month ago

hi @Daniel-W-Innes , any reason you closed this?

Yes, HEXPIRE is from 7.4.0, and I noticed while creating the integration test that it is after the 7.2.6 cut-off for this project.

Daniel-W-Innes commented 1 month ago

I reopened this because I think we can still add the feature, but I'm not sure how you would like me to handle the integration tests.

alicebob commented 1 month ago

Thanks for the explanation, I'll get back to you later. Hasn't happened yet that there were features added from after the license change.

(the PR itself looks nice and clear)

alicebob commented 1 month ago

Hi @Daniel-W-Innes, thanks again for your PR.

I will stick to testing against the last open version of Redis, and that means I can't add things I can't test (if only because it's unmaintainable). If one day a Redis fork shows up I'll keep this PR in mind.