from issue2 about pushState

alicelieutier / smoothScroll

A teeny tiny smooth scroll script with ease-in-out effect and no jQuery.

MIT License

537 stars 127 forks source link

from issue2 about pushState #3

Closed 7cc closed 11 years ago

7cc commented 11 years ago

from the issue : https://github.com/alicelieutier/smoothScroll/issues/2

changed the followings

not to pushState same history
activate :target in Google Chrome
the way to get an element's position(getTop)

By the way, CSS :visited doesn't work in IE(9) when the original event is prevented (I'm using Vista, so I can't test on IE 10).

alicelieutier commented 11 years ago

Thank you for the pull request :) I think it looks good.

However, I have a few comments (you can see them in the 'Files Changed').

Can you change those things or give more details?

I have IE10 on a VM somewhere, once this is changed, I'll test on it. Also, can you update the minified version of the script? I usually use uglify.js for this.

alicelieutier commented 11 years ago

So, if you can just update the lines 61 to 64, I'll merge this. You can just push your changes on the same branch, they will appear here automatically.

Thank you very much for this, and congrats on your first pull request :)

7cc commented 11 years ago

It seems new files ware uploaded successfully. Thank you for help with my first pull request :)

alicelieutier commented 11 years ago

Thank you :+1: