Code Cleanup

[servantftechnicolor]

• Remove samples

• Remove useless software

• Remove structure like access to sfmData views, landmarks and intrinsics

• Remove assignment operator to views and intrinsics (which may create new objects without knowledge)

[simogasp]

I would not remove the samples. It's the easiest way for newcomers to test and learn about the different algorithms and is always a good starting point when developing new algorithms.

[servantftechnicolor]

Samples are a burden to maintain when upgrading the code.

• Who is developing new algorithms similar to the one detailed in the samples ? No new multiview algorithms for 4 years and they were done by insiders.
• There is absolutely no QA on the samples nor test coverage for it.

[simogasp]

Samples are a burden to maintain when upgrading the code.

• Who is developing new algorithms similar to the one detailed in the samples ? No new multiview algorithms for 4 years and they were done by insiders.
• There is absolutely no QA on the samples nor test coverage for it.

Samples are meant as simple test cases for the fundamental bricks of the algorithms. As of today, if you just want e.g. to match two images you have to go through the FeatureMatching software with all the complex interface and data to pass. A simple exe that takes two images and a bunch of parameters is always better than passing through the whole sfmdata etc. And say that one wants to develop a new matching algorithm, he can use the sample as a base (or create a new) one to test it on a simple case, without the hustle and pain of passing through the software and/or meshroom.

Because nobody has contributed yet is not a good reason to remove it, if anything it won't make it more likely. If there are samples where they can start from without passing through the complexity of software exes, it certainly won't discourage them.