search

alicevision / AliceVision

Photogrammetric Computer Vision Framework
http://alicevision.org
Other
2.9k stars 807 forks source link

Unknown Feature Type #1598

Open mh0g opened 7 months ago

mh0g commented 7 months ago

Description

Added an 'unknown' feature type for importing features that are not computed by alicevision.

For now the descriptor size is set to 128, but may be extended and padded with 0 to support wider descriptors in the future.

natowi commented 1 month ago

Why not call it "Custom Feature Type"?

fabiencastan commented 1 month ago

@mh0g Could you rebase, to avoid merge nodes in the PR?

fabiencastan commented 1 month ago

Or "Generic128" ?

MrClock8163 commented 1 month ago

Can I ask why you chose to limit it to 128?

fabiencastan commented 1 month ago

How would you do to get something fully dynamic?

MrClock8163 commented 1 month ago

I meant the question as in, why limit it to such a low number to begin with? I understand that there has to be a limit, but why 128? Granted, 128 is probably more than enough for control points, but if someone would want to import en-masse matches, that would be impossible this way.

fabiencastan commented 1 month ago

128 is for the memory size of each descriptor, not for the number of features/matches.

MrClock8163 commented 1 month ago

I see. I suppose I misunderstood then. Figured this would work the same way as the CCTAG and AprilTag marker describers, where each match is a 128 bytes block, and FF byte in the block identifies the marker ID, which limits it to 128 different markers. Sorry for the confusion.