alicevision / AliceVision

Photogrammetric Computer Vision Framework
http://alicevision.org
Other
2.89k stars 806 forks source link

Remove ceres from automatic public dependencies #1690

Closed servantftechnicolor closed 3 months ago

servantftechnicolor commented 3 months ago

Previously ceres was added to the list of public dependencies of many alicevision libraries. This is convenient because dependency is automatically resolved. However this dependency is propagated also in AliceVisionConfig.cmake, which we don't want for many reasons.

Currently, ceres is deeply rooted inside many part of alicevision for no reasons. Mostly because BundleAdjustmentCeres.hpp declares a lot of ceres objects in its interface. A more future proof workaround would be to make this more private but would take more time to do.