search

alicevision / AliceVision

Photogrammetric Computer Vision Framework
http://alicevision.org
Other
2.89k stars 806 forks source link

Add condition to check dependency MeshSDFilter folder #1704

Closed JackBoosY closed 2 months ago

JackBoosY commented 2 months ago

Implementation remarks

FTR https://github.com/alicevision/AliceVision/issues/767#issuecomment-2042771385

The check should requires ALICEVISION_USE_MESHSDFILTER is ON.

servantftechnicolor commented 2 months ago

Sorry, but this PR is not valid or at least incomplete.

I think this condition is meant to check that the submodules have been retrieved and exit early. There is not only MeshSDFilter but also NanoFlann. If we merge this PR, then we should add a second test for nanoflann submodule.

simogasp commented 2 months ago

Sorry, but this PR is not valid or at least incomplete.

I think this condition is meant to check that the submodules have been retrieved and exit early. There is not only MeshSDFilter but also NanoFlann. If we merge this PR, then we should add a second test for nanoflann submodule.

That's the point. Nanoflann is mandatory and we don't check it, MeshSDFilter and we check. So either we don't check either of them or we check both of them. MeshSDFilter should be checked the way this PR suggests because it's optional, if anything we should add a check for nanoflann

JackBoosY commented 2 months ago

So either we don't check either of them or we check both of them.

Should I also add check for NanoFlann in this PR?

JackBoosY commented 2 months ago

Ping @simogasp for review again.

simogasp commented 2 months ago

@JackBoosY Thanks!